Is My Portfolio Good Enough? Five Tests, and the One That Decides

Over the same window, did it do better or worse than simply owning the market?

This is the test people mean and rarely run correctly. Two traps: comparing your price return against the index's total return, which quietly hands the index the dividends and makes you look worse; and choosing a single window, which can say almost anything. Run three windows and be consistent about dividends on both sides.

Passing looks like. Within a point or two either side over several years is ordinary. A persistent gap of several points is worth explaining.

The method, including the dividend trap, is in how to compare your portfolio to the S&P 500.

What share sits in the single largest company once you look inside the funds?

Almost nobody sets out to be concentrated. It arrives through employer stock, through a winner that ran, or through three broad funds that each hold the same large technology companies. A portfolio can look diversified by fund count and be a bet on eight companies.

Passing looks like. No single company much above a tenth of the whole, unless you decided that deliberately and can say why.

See how to check portfolio concentration, and how to find overlap in your ETFs for the case where three funds are quietly one bet.

What is the weighted average expense ratio across everything you hold?

Cost is the only input to future returns you control with certainty, and most people have never calculated theirs. It compounds silently in the wrong direction, and a portfolio that is otherwise fine can be quietly leaking through an expensive fund nobody has looked at since it was bought.

Passing looks like. Broad index funds sit in the hundredths of a percent. Well above half a percent needs a reason you agree with.

See what an expense ratio is.

When will you need this money, and does the mix reflect that rather than a number you picked once?

This is where portfolios fail hardest and least visibly. A house deposit in an aggressive allocation is fine until the year you need it, and a thirty-year retirement account sitting mostly in cash is failing continuously and quietly. Neither shows up in a performance number.

Passing looks like. Money needed inside a few years should not be sitting in a portfolio that can halve.

If this fell by a third, would you still be holding it eighteen months later?

The only test that decides anything, and the only one no calculation answers. A theoretically excellent portfolio you sell at the bottom is worse than a mediocre one you keep. Your own history is the evidence: what did you do the last time markets fell?

Passing looks like. An honest yes, based on what you did last time rather than what you intend.

All four share a flaw: they can be satisfied by a portfolio that is doing badly on the things that matter, and failed by one that is doing everything right. A diversified portfolio holding bonds and international stocks will lose to a US large-cap index in the years US large caps lead, every time, by design. That is not a failing grade, it is the diversification you paid for behaving as advertised.

When a portfolio persistently trails, the cause is rarely bad luck and almost never bad stock picking. In order of frequency it is cost, a fund charging well above the index equivalent for the same exposure; concentration, a single position or sector that dominated the outcome in both directions; and cash, a slice sitting uninvested for years without anyone deciding it should.

All three are fixable and none requires better judgement about markets. That is the encouraging part of the diagnosis: the common problems are structural, and structure is exactly what you can change.

A portfolio that is optimal on paper and that you abandon in a bad year has performed worse than an ordinary one you held. Every measurable test above assumes you stay invested, and that assumption is doing more work than the arithmetic.

The way to answer it honestly is to look at what you did rather than what you intend. If you sold something during the last significant fall, that is the most reliable data you have about your own tolerance, and it is worth more than any risk questionnaire. The response is not to feel bad about it; it is to hold a mix you can actually sit through, which usually means a bit less in stocks than the theoretical optimum.

The word “enough” is doing quiet work in the question, and it is worth making it explicit, because a portfolio can only be adequate relative to a job. Enough to fund a house deposit in three years is a completely different specification from enough to fund forty years of retirement, and the same holdings can pass one and fail the other badly.

Write the job down before judging the portfolio against it. How much, by when, and what happens if it is short. A portfolio that will plausibly get there with room to spare does not need optimising; it needs leaving alone. One that will not get there is not fixed by picking better holdings, it is fixed by saving more, extending the horizon, or accepting a smaller number, and no rearrangement of funds substitutes for that arithmetic.

This is the most common reason a technically fine portfolio still fails. Nothing is wrong with it. It is simply too small for what is being asked, and that is a savings problem wearing an investing costume.

Cost and overlap are usually a same-day fix. Concentration and horizon mismatch often are not, particularly in a taxable account where correcting them realises gains, and that is where the sequencing question starts to be worth real advice. See how to tell if your portfolio needs changing and, if you are considering paying someone, what to know before the first advisor meeting.